Forged Alliance Forever

Re: Zoom pop working or not?

2017-06-20T12:59:31+02:00

PhilipJFry wrote:
If you take a look at github link from KeyBlue you might notice that the PR has been merged (which means that the change has been accepted).
And if you take a look at the current develop patch in the FAF client you'll notice that the zoom pop works there.
So it is already fixed and as soon as the next patch gets rolled it will work for everyone again.

Thank you.

Statistics: Posted by Spyder — 20 Jun 2017, 12:59

Re: Zoom pop working or not?

2017-06-20T08:04:02+02:00

Spyder wrote:
I was about to post a detailed bug report on the problem I was having with zoom pop not working when I found this thread. Looks like it was a simple fix- should we expect to see the fix implemented in the next patch? I did notice that this thread took place on May 19th, and the most recent patch (3684) was on May 27th and the problem still exists.

I just want to please add... Just fix it. Don't implement the UI Party method. Everyone who wants the UI Party method is running UI Party already anyway, and they can check the option box. I run UI Party as well and prefer the classic zoom pop. I think that's how it should stay- as an option for those who want it.

Really looking forward to restored zoompopper functionality... my FAF experience simply isn't the same without it.

Thank you very much

If you take a look at github link from KeyBlue you might notice that the PR has been merged (which means that the change has been accepted).
And if you take a look at the current develop patch in the FAF client you'll notice that the zoom pop works there.
So it is already fixed and as soon as the next patch gets rolled it will work for everyone again.

Statistics: Posted by PhilipJFry — 20 Jun 2017, 08:04

Re: Zoom pop working or not?

2017-06-20T07:18:11+02:00

Statistics: Posted by nine2 — 20 Jun 2017, 07:18

Re: Zoom pop working or not?

2017-06-20T05:09:24+02:00

I was about to post a detailed bug report on the problem I was having with zoom pop not working when I found this thread. Looks like it was a simple fix- should we expect to see the fix implemented in the next patch? I did notice that this thread took place on May 19th, and the most recent patch (3684) was on May 27th and the problem still exists.

I just want to please add... Just fix it. Don't implement the UI Party method. Everyone who wants the UI Party method is running UI Party already anyway, and they can check the option box. I run UI Party as well and prefer the classic zoom pop. I think that's how it should stay- as an option for those who want it.

Really looking forward to restored zoompopper functionality... my FAF experience simply isn't the same without it.

Thank you very much

Statistics: Posted by Spyder — 20 Jun 2017, 05:09

Re: Zoom pop working or not?

2017-05-22T02:27:59+02:00

This sounds like a really good feature and if you can make it work reliably you should make a PR to fafmod.

In the startup sequence it actually quickly zooms the camera in and out about the map to work out the pixel to worldspace ratio that results in better zoom popping

Is the ratio the same on every map? Then it could just be hardcoded.

Statistics: Posted by DukeOfEarl — 22 May 2017, 02:27

Re: Zoom pop working or not?

2017-05-20T08:34:43+02:00

Hi R_Charger, you can use any code from UI Party that you want - but I think it's a bad idea. I made it whilst learning fa + lua and I did some pretty noob things.

Hotbuild's zoom pop is meant to be a button where you can zoom in and out really quickly. Unfortunately it zooms in to an inexact place, which is really jarring because after zooming in, you don't know where you are, which makes it unusable.

Steps to illustrate problem:
- zoom right out on a big map.
- start placing a factory near a mex near a map corner, as in show the green building placeholder next to a mex
- zoom pop in
- at this point you would expect to be zoomed in with the factory placeholder near the mex still, but it's not.
- now install UI Party and repeat the experiment for a much better experience

UI Party fixes this by doing some very dodgy things. In the startup sequence it actually quickly zooms the camera in and out about the map to work out the pixel to worldspace ratio that results in better zoom popping. It comes up with a ratio that is much more accurate (but still not totally accurate). The hack also slightly changes the startup angle of the camera.

I would suggest that such a hack has no place in production code. Perhaps a real fix is possible but I imagine you guys have more important things to invest in. I personally personally don't even use the "fixed" version of zoom pop because it is still annoying.

What you could do though is get zoom pop working at all -> I believe the keybinding action is broken somehow. Like something got renamed in code but the action that invokes it did not. Then people would have the option of using hotbuild or UI Party zoompop. Edit: oh ok i see you have done that already, sweet thanks

I can make a video to explain it all if you really want but I don't think this is worth your effort.

Statistics: Posted by nine2 — 20 May 2017, 08:34

Re: Zoom pop working or not?

2017-05-20T02:10:17+02:00

Well I'll look at what you got. And see if we can steal some of your ideas.
But if its actually a big hack, it probably will stay as it is for now.

I assume you don't mind if we did use some of your code?

Statistics: Posted by KeyBlue — 20 May 2017, 02:10

Re: Zoom pop working or not?

2017-05-20T00:14:51+02:00

Zoom pop was originally introduced in hotbuild, its not part of FA. My "fix" is the most unpleasant hack in the world.

Statistics: Posted by nine2 — 20 May 2017, 00:14

Re: Zoom pop working or not?

2017-05-19T20:11:05+02:00

Ok thanks for finding that KeyBlue. I still think the fix in UI party (zoompopper.lua) should be implemented in FAF. No reason why it shouldn't be fixed for everyone.

Statistics: Posted by R_Charger — 19 May 2017, 20:11

Re: Zoom pop working or not?

2017-05-19T18:36:49+02:00

alright, I fixed it. It was just some missing "/".
https://github.com/FAForever/fa/pull/2006

@Anihilnine, I couldn't find an issue about it on github.
And you just mentioned it on slack while complaining about having to move the modules files. (not even in bugreports channel)
Nobody seemed to respond to it and then it just got drowned out by other stuff.
That can hardly be called proper bug reporting.

It's not your duty to make good reports, so thats not an issue.
Just don't claim you reported it and make it look like the devs completely ignored you when you didn't put in much effort in letting them know either.

Statistics: Posted by KeyBlue — 19 May 2017, 18:36

Re: Zoom pop working or not?

2017-05-19T17:02:40+02:00

You press one key and it zooms in/zooms out to instantly. No rolling the mouse wheel. The version in Forged Alliance has always been a bit rubbish as it didn't exactly zoom in/out where the cursor was. This was fixed in UI Party and worked perfectly.Its not working at all has happened since after 3680 (it was working with the refactored UI party for 3680). Really the fix in UI party should be integrated as it corrects a fault rather than just changes the UI.

Statistics: Posted by R_Charger — 19 May 2017, 17:02

Re: Zoom pop working or not?

2017-05-19T16:24:34+02:00

What is zoom pop feature anyway?
This is the first time I hear about it...

Statistics: Posted by KeyBlue — 19 May 2017, 16:24

Re: Zoom pop working or not?

2017-05-19T12:34:57+02:00

Hmmm 2 steps forward one step back. Can it please be fixed in a new patch? Also would be an idea to fix it so it works properly like in UI party!

Statistics: Posted by R_Charger — 19 May 2017, 12:34

Re: Zoom pop working or not?

2017-05-19T11:15:23+02:00

They cleaned up the zoom pop feature.

This is a smart mouth joke. They tried to clean the code and broke the feature. I reported it and they left it broken. Not sure where it is at.

Statistics: Posted by nine2 — 19 May 2017, 11:15

Zoom pop working or not?

2017-05-19T11:11:04+02:00

Since patch 3682 my zoom pop key is not working (which I like to use). Is anyone using this key and experienced anything similar?

Statistics: Posted by R_Charger — 19 May 2017, 11:11