Forged Alliance Forever

Re: Unable to patch game in FAF

2017-09-05T14:57:36+02:00

Hi,

great debugging.

confirmed, the log is flushed to file on lobby shutdown, which means issues (such as this one) where the process becomes non responsive will not be captured in logs

You can change the log buffer size using the "FA Lobby.ini" file.

I'll play around a little to see if I can fix it with my local files

To set up a local development environment on windows, follow the instructions here: https://github.com/faforever/client/wik ... -Miniconda (It's a bit painful, sadly)

On linux, you just need to install dependencies (pip install -r requirements.txt in a virtualenv works fine) and then you can run from source.

Statistics: Posted by DukeOfEarl — 05 Sep 2017, 14:57

Re: Unable to patch game in FAF

2017-09-05T11:55:07+02:00

Thanks. Took me a while to find the right place, but I'm reasonably certain the problem lies in:
https://github.com/FAForever/client/blo ... #L344-L353

Specifically, that the read call on line 348 won't respect the timeout as you'd expect (issue plus work around discussed here: https://stackoverflow.com/questions/811 ... nterrupted)

Because it blocks forever, and there's no threading going on, the process events call doesn't happen, so windows correctly considers the process non responsive.

I'll play around a little to see if I can fix it with my local files, then post an issue. I'm not competent enough to do a proper pull request, but hopefully the details I've found will help someone who can do it better
[edit] I can't play around locally, because the python files appear to have been all compiled into the executable? Guess I'll just raise the issue on github

Statistics: Posted by thetrav — 05 Sep 2017, 11:55

Re: Unable to patch game in FAF

2017-09-05T10:49:48+02:00

the client checks for files in that folder otherwise people would download every file every time they join/host games
the .nx2 files are just renamed archives (similar to the .scd files in your fa install directory)
everything is open source and available on github
client logs are being written upon closing the client
also if your client is unable to write logs then your issue is actually most certainly not the same as the one from the OP

Statistics: Posted by PhilipJFry — 05 Sep 2017, 10:49

Re: Unable to patch game in FAF

2017-09-05T10:50:11+02:00

C:\ProgramData\FAForever\logs\forever.log?

It doesn't write anything while attempting this task. I cleared the folder, started the lobby, double clicked the first thing on the coop campaigns (some UEF mission) it downloaded a bunch of files, then got stuck on one.

The process becomes non-responsive and needs to be terminated, file is empty.
My best guess is that the log file isn't flushed so nothing gets written to file.

[EDIT] confirmed, the log is flushed to file on lobby shutdown, which means issues (such as this one) where the process becomes non responsive will not be captured in logs

WRT the .nx2 files, it's a zip file alright, I can open it with 7zip, however the extension is not .zip, it's .nx2
My best guess is that the lobby software isn't checking for a file existing in that folder before it decides to download it

The lobby isn't open source by any chance is it?

Statistics: Posted by thetrav — 05 Sep 2017, 10:43

Re: Unable to patch game in FAF

2017-09-04T07:46:07+02:00

please post your forever.log file (no offense but you saying "i have the same issue" might be incorrect and giving advice based on logs is a lot better)

the .nx2 files are located in C:\ProgramData\FAForever\gamedata which is a folder that windows hides by default in the explorer so you either copy paste the path into the explorer or enable to show hidden folders in the explorer settings to find it.
The file you get when grabbing it manually from the server is probably a .zip file and not a .nx2 file so you have to rename it.

For 99.9% of the FAF userbase the automated patching does work. Giving the files directly to the rest wouldn't help them either probably cause they'd have to put them in again every time they get a new patch (assuming they have the capability to put them in the right directory) due to updates or watching old replays. Helping them to fix their overprotective AV software is the better solution.

Statistics: Posted by PhilipJFry — 04 Sep 2017, 07:46

Re: Unable to patch game in FAF

2017-09-04T07:15:31+02:00

DukeOfEarl wrote:
This is the fault of your antivirus.

What makes you so certain it's the antivirus? I only had windows defender installed, and I attempted with it disabled to no avail.

Wouldn't an anti-virus interfering give some indication that it was doing so? A message to ensure us that it had done it's job?

Statistics: Posted by thetrav — 04 Sep 2017, 07:15

Re: Unable to patch game in FAF

2017-09-03T01:22:45+02:00

Also frustrating, when I download the file from the URL the lobby mentions, and place it in C:\ProgramData\FAForever\gamedata the lobby still tries to re-download the same file.

Is it not possible to just give us a zip that we can download and extract manually? Would save a lot of bother here

Statistics: Posted by thetrav — 03 Sep 2017, 01:22

Re: Unable to patch game in FAF

2017-09-03T00:44:02+02:00

I have the same issue. Best I can tell the download hangs (my PC stops receiving packets) and the lobby stops responding.

Seems like the UI could at least be fixed so that a hung download doesn't break the UI.

Where do you end up copying the files? I'm trying the manual download, but can't find any folders with .nx2 files in it

Statistics: Posted by thetrav — 03 Sep 2017, 00:44

Re: Unable to patch game in FAF

2017-06-25T12:53:12+02:00

Hi,

I resolved this issue.
I managed to download the 40 mb file from my other computer after several attempts and copied the file to my computer.
It's not the antivirus as I disabled it and still had the problem.
It appears to happen on the larger download files with message not responding when the download stops.
This also happens when downloading a large mod from the vault.

Statistics: Posted by Starheaven — 25 Jun 2017, 12:53

Re: Unable to patch game in FAF

2017-06-24T08:00:23+02:00

This is the fault of your antivirus.

Statistics: Posted by DukeOfEarl — 24 Jun 2017, 08:00

Re: Unable to patch game in FAF

2017-06-24T00:19:24+02:00

Hi,

Is it possible to attach the faf file/units.3684.nx2 here so i can past it in my game data folder.
i am unable to get past this 40mb file update the update stops downloading between 18%-30% tried several times without any success.

Thanks

Statistics: Posted by Starheaven — 24 Jun 2017, 00:19

Re: Unable to patch game in FAF

2017-06-22T12:04:01+02:00

Hi,

I uninstalled FAF and re installed v0.12.4.
i tried to host game and it went through some downloads then I get not responding at fa files/textures.3684.nx2.
I closed FAF and re started FAF and hosted the same game. The update commenced from where it left off and downloaded the above file then it came to updating fa files/units.3684.nx2 a 40mb file it stopped responding at 30% of the download.
I closed the program and restarted FAF host same game and it started to update the same file from the start each time at around 25% to 38% the file stops downloading and get stopped responding. I tried several times and it keeps stopping midway through this update.
I have attached new log files below.
Hope you can help
Thanks

Statistics: Posted by Starheaven — 22 Jun 2017, 12:04

Re: Unable to patch game in FAF

2017-06-20T13:16:26+02:00

Thank you for your help
I"ll give that a try

Statistics: Posted by Starheaven — 20 Jun 2017, 13:16

Re: Unable to patch game in FAF

2017-06-20T13:11:53+02:00

very strange... still no errors/warnings in the log
Stuff you could try:

C:\ProgramData\FAForever

FAF client version

downlords client

Statistics: Posted by PhilipJFry — 20 Jun 2017, 13:11

Re: Unable to patch game in FAF

2017-06-20T13:04:58+02:00

Hi,

I have closed FAF client and re uploaded the log files.

thank you

Statistics: Posted by Starheaven — 20 Jun 2017, 13:04