Forged Alliance Forever

Re: I fixed the Ladder Leaderboards RSQL filter

2018-05-30T00:03:19+02:00

The fix is now deployed.

Statistics: Posted by Brutus5000 — 30 May 2018, 00:03

Re: I fixed the Ladder Leaderboards RSQL filter

2018-05-29T21:18:44+02:00

Good catch Mmkay! Will be deployed soon! Thanks for the PR Wesmania.

Statistics: Posted by Brutus5000 — 29 May 2018, 21:18

Re: I fixed the Ladder Leaderboards RSQL filter

2018-05-29T21:01:12+02:00

https://github.com/FAForever/website/pull/145

Statistics: Posted by Wesmania — 29 May 2018, 21:01

Re: I fixed the Ladder Leaderboards RSQL filter

2018-05-29T20:55:39+02:00

A little investigation into website source suggests that the offending line is public/js/app/leaderboards.js:136. A git grep for 'ratingType' suggests we should compare ratingType to 'ladder1v1' rather than '1v1'. I'll see about making a PR to the repo.

Statistics: Posted by Wesmania — 29 May 2018, 20:55

I fixed the Ladder Leaderboards RSQL filter

2018-05-29T20:28:45+02:00

Here: https://www.faforever.com/competitive/leaderboards/1v1

URL currently is [url]https://api.faforever.com/data/gamePlayerStats?filter=player.id==781;game.featuredMod.technicalName=faf&fields[gamePlayerStats]=afterMean,afterDeviation,scoreTime[/url]

Should be [url]https://api.faforever.com/data/gamePlayerStats?filter=player.id==781;game.featuredMod.technicalName==ladder1v1&fields[gamePlayerStats]=afterMean,afterDeviation,scoreTime[/url]

Statistics: Posted by Mmkay — 29 May 2018, 20:28