Unit Sharing on always against AI

[oldngrey]

Has anyone else noticed this?
When playing Skirmish with the Sorian Rush AI, if an AI team mate dies I get all his units despite share until death being on.
At a guess I'd say it has been doing this for a few weeks now.

FAF version: 0.11.60+577

[Uveso]

"share until death" (Option: Share Conditions) ? You can't share units with an AI.

Maybe you mean "Share Unit Cap at Death" ?
If this is set to "Allies" or "All", then you will get Units from an AI after the Ai is dead.

[oldngrey]

Thanks for the info about Share Until Death not applying to the AI. Didn't know that. (I have never tried to donate units to the AI!)

However, "Share Unity Cap at Death" is set to NONE and when an AI team mate dies I get his base and units. As I said, that appears to have only started happening in the last few weeks.

I ask again, has anyone else noticed the AI donating at their death? It's kinda ruining the AI skirmish for me.
Or to put it another way, does anyone play against the AI and NOT seen this happen, say this week?

[Plasia]

Bug confirmed

Settings, full share is off

Untitled.png (27.63 KiB) Viewed 1169 times

(replay on Goodlands)

aibugshort.SCFAReplay

Replay showing the bug happening

(51.27 KiB) Downloaded 39 times

[Uveso]

Thanks for posting this.

I am already on it, and i found out, why this is happened.
First of all, the sorian Ai is ignoring the option. Maybe a import mistake.
And the function itself, is always transfering ownership of all units, and does not check, if those units are borrowed from another player.
i will fix this tonight.

[oldngrey]

Good work Uveso.
Are you saying that the Sorian AI has always ignored the option? I have definitely seen empty AI bases in the past. I can't recall if it was Sorian or Sorian Rush.

And thanks Plasia.

[Uveso]

Fix is ready for testing:
Additional Infos:
https://github.com/FAForever/fa/pull/1404