I fixed the Ladder Leaderboards RSQL filter [SOLVED]

This is for troubleshooting of problems with the FAF client and Forged Alliance game.

Moderator: PhilipJFry

Forum rules


BEFORE POSTING read


Our wiki contains a lot of helpful material about technical issues, try looking there first!

Use the search function before opening a thread! (https://www.faforever.com/forums/search.php)

Read this before posting here: https://wiki.faforever.com/index.php?ti ... cal_Issues
Post a reply

I fixed the Ladder Leaderboards RSQL filter

Postby Mmkay » 29 May 2018, 20:28

Here: https://www.faforever.com/competitive/leaderboards/1v1

URL currently is [url]https://api.faforever.com/data/gamePlayerStats?filter=player.id==781;game.featuredMod.technicalName=faf&fields[gamePlayerStats]=afterMean,afterDeviation,scoreTime[/url]

Should be [url]https://api.faforever.com/data/gamePlayerStats?filter=player.id==781;game.featuredMod.technicalName==ladder1v1&fields[gamePlayerStats]=afterMean,afterDeviation,scoreTime[/url]
Mmkay
 
Posts: 9
Joined: 25 Apr 2015, 18:56
Has liked: 4 times
Been liked: 5 times
FAF User Name: Mmkay
Top

Re: I fixed the Ladder Leaderboards RSQL filter

Postby Wesmania » 29 May 2018, 20:55

A little investigation into website source suggests that the offending line is public/js/app/leaderboards.js:136. A git grep for 'ratingType' suggests we should compare ratingType to 'ladder1v1' rather than '1v1'. I'll see about making a PR to the repo.
Wesmania
Contributor
 
Posts: 391
Joined: 19 Nov 2014, 19:17
Has liked: 2 times
Been liked: 79 times
FAF User Name: MazorNoob
Top

Re: I fixed the Ladder Leaderboards RSQL filter

Postby Wesmania » 29 May 2018, 21:01

https://github.com/FAForever/website/pull/145
Wesmania
Contributor
 
Posts: 391
Joined: 19 Nov 2014, 19:17
Has liked: 2 times
Been liked: 79 times
FAF User Name: MazorNoob
Top

Re: I fixed the Ladder Leaderboards RSQL filter

Postby Brutus5000 » 29 May 2018, 21:18

Good catch Mmkay! Will be deployed soon! Thanks for the PR Wesmania.
The 9th Doctor wrote:You think it'll last forever, the people and cars and concrete. But it won't. One day it's all gone, even the sky.
Brutus5000
Councillor - DevOps
 
Posts: 366
Joined: 05 Aug 2016, 23:32
Has liked: 29 times
Been liked: 288 times
FAF User Name: brutus5000
Top

Re: I fixed the Ladder Leaderboards RSQL filter  [SOLVED]

Postby Brutus5000 » 30 May 2018, 00:03

The fix is now deployed.
The 9th Doctor wrote:You think it'll last forever, the people and cars and concrete. But it won't. One day it's all gone, even the sky.
Brutus5000
Councillor - DevOps
 
Posts: 366
Joined: 05 Aug 2016, 23:32
Has liked: 29 times
Been liked: 288 times
FAF User Name: brutus5000
Top
Post a reply

Return to Tech Support

Who is online

Users browsing this forum: No registered users and 1 guest