by Ze_PilOt » 19 Feb 2015, 10:07
Xinnony doesn't speak english very well, but he tried to warn the coder team about changing every function in the game for "clarity" and "cleaness". His code is probably not the cleanest ever, but he has deep understanding of how the lobby truly works, and his works toward effectiveness. He shouldn't be ignored but respected. Up to the coder team to accept that go past the language barrier.
I would say that cleaning up code is important, but not as much as other priorities that FAF really need. At least, it shouldn't be done on a production patch, but on a beta, and not before the production server is stable (and it seems that it's not since it moved to a new server, things got lost in the process). A clean code is useless and counter-productive if it breaks things.
The coder team will probably ignore my advice, but they should revert every change they done and only include real bug fixes until they have a proper environment to test the refactoring. FAF is back to alpha/beta stage, that's a huge step back IMHO.
Given all the changes that were done, and my experience on working on the same code, I would say that it need a least 6 months of work before being pushed in production (and that's if they don't introduce new changes, something that is done almost on a daily basis).
I'm sure sheeo is competent, but I think he under-estimate greatly the impact of changing a single line of code in FA.
For reference, it took a team of 4 competent coders (Moritz, FunkOff, Thygrr and me) a year to bring changes tested for years in mods to the main codebase without any bug occurring, and the code was much simpler back then.
There is also very good reasons, improved and tested for 3 years, for the code being organized the way it is currently. Changing it is not without consequences, and shouldn't be done without strongly thinking about it. The new team thought I wasn't pushing changes fast enough, I hope you understand why now.
Nossa wrote:I've never played GPG or even heard of FA until FAF started blowing up.